feat: add game history tracking and average calculation to BasketballPlayerStats#1
Open
jordanceldridge13 wants to merge 1 commit intocode-differently:mainfrom
Open
Conversation
…calculation with full test coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Object Chosen
I chose BasketballPlayerStats because it models real-world player performance data and allowed me to practice meaningful object behavior beyond simple getters and setters. Basketball statistics naturally support custom methods like recording games and calculating averages, which made it a strong fit for TDD.
JaCoCo Coverage
Current JaCoCo coverage: 92% overall instruction coverage
BasketballPlayerStats: 93%
GameStat: 84%
This exceeds the 80% requirement.
Challenges / Interesting Findings
One interesting challenge was refactoring calculatePointsPerGame() to derive the average from recorded games instead of passing in gamesPlayed. This required introducing a GameStat class and storing game history inside the object.